Use --ephemeral by default #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every runner is now
--ephemeralby default.Note that this works by ARC setting the
RUNNER_FEATURE_FLAG_EPHEMERALenvvar totrueby default. Previously you had to explicitly set it totrueotherwise the runner was passed--oncewhich is known to various race conditions.It's worth noting that the very confusing and related configuration,
ephemeral: true, which creates--oncerunners instead of static(or persistent) runners had been the default since many months ago. So, this should be the only change needed to make every runner ephemeral without any explicit configuration.You can still fall back to static(persistent) runners by setting
ephemeral: false, and to--oncerunners by settingRUNNER_FEATURE_FLAG_EPHEMERALto"false". But I don't think there're many reasons to do so.Ref #1189